Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

corrected handling of 2 error cases #54

Merged
merged 1 commit into from
Jan 16, 2024
Merged

corrected handling of 2 error cases #54

merged 1 commit into from
Jan 16, 2024

Conversation

bigcat88
Copy link
Member

@bigcat88 bigcat88 commented Jan 5, 2024

  1. request_integration can return error, check for that was missing.
    Fixes: Error: Call to a member function getBody() on array error on nextcloud.log
  2. By adding parentheses around $result['error_description'] ?? '[no error description]', we ensure that the null coalescing operator correctly provides a fallback string when error_description is not available in the $result array.
    Fixes: Undefined array key "error_description" at /var/www/html/apps-extra/integration_jira/lib/Service/NetworkService.php#225

@bigcat88 bigcat88 requested a review from julien-nc January 5, 2024 13:55
@bigcat88
Copy link
Member Author

bigcat88 commented Jan 8, 2024

I tested this PR for a week, and looks like I cannot reproduce #32 , so probably this PR fixes that issue.

@bigcat88 bigcat88 merged commit cfa9599 into main Jan 16, 2024
18 checks passed
@delete-merged-branch delete-merged-branch bot deleted the small-fixes branch January 16, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-nc julien-nc julien-nc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bigcat88 @julien-nc